Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light driver for PCA9632 #17557

Merged
merged 10 commits into from
Jan 1, 2023
Merged

Light driver for PCA9632 #17557

merged 10 commits into from
Jan 1, 2023

Conversation

kaedwen
Copy link
Contributor

@kaedwen kaedwen commented Dec 31, 2022

Description:

This PR adds a raw PCA9632 driver and a light driver for that device. It can be configured with the USE_PCA9632 defines. The I2C address and the channel mapping can be configured.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.6
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@@ -632,6 +632,12 @@
// #define USE_PCA9685 // [I2cDriver1] Enable PCA9685 I2C HW PWM Driver - Must define I2C Address in #define USE_PCA9685_ADDR below - range 0x40 - 0x47 (+1k4 code)
// #define USE_PCA9685_ADDR 0x40 // Enable PCA9685 I2C Address to use (Must be within range 0x40 through 0x47 - set according to your wired setup)
// #define USE_PCA9685_FREQ 50 // Define default PWM frequency in Hz to be used (must be within 24 to 1526) - If other value is used, it will rever to 50Hz
// #define USE_PCA9632 // [I2cDriver91] Enable PCA9632 I2C HW PWM Driver
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be I2cDriver75

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed to I2cDriver75

@@ -0,0 +1,275 @@
/*
xdrv_15_pca9632.ino - Support for I2C PCA9632 4bit 8 pin hardware PWM driver on Tasmota
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be xdrv_91_pca9632.ino

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed to xdrv_91_pca9632.ino

@arendst arendst merged commit 25b4040 into arendst:development Jan 1, 2023
arendst added a commit that referenced this pull request Jan 1, 2023
Add support for PCA9632 4-channel 8-bit PWM driver as light driver by Pascal Heinrich (#17557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants