SGP4X Driver - Adding SGP40 support to Universal SGP4X Driver #19560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
precurse
force-pushed
the
sgp40and41
branch
from
51c93b8 to
1324f0e
Compare
s-hadinger
requested changes
Sep 21, 2023
precurse
force-pushed
the
sgp40and41
branch
from
1324f0e to
54894b9
Compare
precurse
force-pushed
the
sgp40and41
branch
from
54894b9 to
53fee6b
Compare
|
Should be good now @s-hadinger. Let me know if you need anything else. Cheers! |
s-hadinger
approved these changes
Sep 22, 2023
|
Thanks for your contribution |
dilyanpalauzov
pushed a commit
to dilyanpalauzov/Tasmota
that referenced
this pull request
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This patch adds supports for the SGP40 sensor as well, eliminating the need for a separate SGP40 library. Previously, one had to custom compile Tasmota for the ESP8266, and disabled the SGP40 (
i2cdriver69) in order for it to work. This can handle both pieces of hardware now. Eventually the SGP40 driver can be retired.Related issue (if applicable): fixes #
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass