Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeoPool make compiler setting available by user_config_override.h #21645

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

curzon01
Copy link
Contributor

Description:

Following compiler settings for NeoPool can alternatively now also be set within user_config_override.h:

// Modbus settings
#define NEOPOOL_MODBUS_SPEED         19200
#define NEOPOOL_MODBUS_ADDRESS       1      // Modbus address, "WIFI" uses 1, "EXTERN" defaults also 1
#define NEOPOOL_READ_REGISTER        0x04   // Modbus function code used to read register
#define NEOPOOL_WRITE_REGISTER       0x10   // Modbus function code used to write register
#define NEOPOOL_READ_TIMEOUT           25   // Modbus read data timeout in ms
#define NEOPOOL_CACHE_INVALID_TIME     30   // Modbus data cache invalidation time in s

// Pool LED RGB lights with different programs, the individual programs can be selected
// by switching them off and on again for a defined time when the LED is switched on.
// Default timings for LED light program step sequence (NPLight 3)
#define NEOPOOL_LIGHT_PRG_WAIT       30     // Pool LED RGB light delay before start prg light if light was off (in ms)
#define NEOPOOL_LIGHT_PRG_DELAY      15     // Pool LED RGB light default next light prg delay (in ms)
#define NEOPOOL_LIGHT_PRG_DELAY_MIN  5      // Pool LED RGB light next light prg delay min (in ms)
#define NEOPOOL_LIGHT_PRG_DELAY_MAX  100    // Pool LED RGB light next light prg delay max (in ms)

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.6
  • The code change is tested and works with Tasmota core ESP32 V.3.0.1
  • I accept the CLA.

@arendst arendst merged commit 2ce513f into arendst:development Jun 16, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants