Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Berry webserver_async #21836

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Conversation

s-hadinger
Copy link
Collaborator

@s-hadinger s-hadinger commented Jul 24, 2024

Description:

Add Berry webserver_async for features like real-time logs or real-time debugging information.

[Edit]
Flash increase: 8.8KB only if USE_BERRY_DEBUG is defined

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.7
  • The code change is tested and works with Tasmota core ESP32 V.3.0.2
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@Jason2866
Copy link
Collaborator

Jason2866 commented Jul 24, 2024

Mhh, nearly 11kb. Needs this feature to be solidified? One of the great Berry benefits is not to add not often used/needed features to every build.

Wouldn't it be possible to do as compile time option?

  • Standard build leave everything as it is currently.
  • Debug build, embedding Berry Async Web Server

@s-hadinger
Copy link
Collaborator Author

Let's put on hold for now, I have some more optimization, and will put it only with USE_BERRY_DEBUG

@s-hadinger
Copy link
Collaborator Author

webserver_async now reduced to 9KB, and only included if USE_BERRY_DEBUG is enabled

@s-hadinger s-hadinger merged commit 55cb473 into arendst:development Jul 26, 2024
59 checks passed
hawa-lc4 pushed a commit to hawa-lc4/Tasmota-dev that referenced this pull request Aug 8, 2024
* Berry `webserver_async`

* Shrink size and include only when USE_BERRY_DEBUG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants