Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Berry internal: remove class from closure to simplify code #21839

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

s-hadinger
Copy link
Collaborator

@s-hadinger s-hadinger commented Jul 24, 2024

Description:

Berry revert of #21490
This PR introduced complexity in storage that is finally not worth it, as I found a different way to mutualize code in Matter. The same effect could be implemented at Solidification time, without changing the solidified code.

No functional change.

Code reduced by 1.8KB

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.7
  • The code change is tested and works with Tasmota core ESP32 V.3.0.2
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@s-hadinger s-hadinger merged commit bf7fbf2 into arendst:development Jul 24, 2024
59 checks passed
hawa-lc4 pushed a commit to hawa-lc4/Tasmota-dev that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant