uDisplay force cache writes to RGB display on ESP32S3 #22222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix visible artifacts on ESP32S3 with RGB displays. The problem is caused by cache lines not being flushed after updating the display (the internal memory is updated but writes to PSRAM which stored the frame buffer are delayed until cache lines are reclaimed).
It seems that the previously used
esp_cache_msync()
does not work anymore, it is replace byCache_WriteBack_Addr()
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass