Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MS5837 functionality with BMP280 optional dependency #22376

Merged
merged 19 commits into from
Nov 8, 2024
Merged

MS5837 functionality with BMP280 optional dependency #22376

merged 19 commits into from
Nov 8, 2024

Conversation

vtHydroponics
Copy link
Contributor

Description:

Related issue (if applicable): fixes #

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.8
  • The code change is tested and works with Tasmota core ESP32 V.3.1.0.241023
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@vtHydroponics vtHydroponics requested a review from arendst October 29, 2024 14:01
arendst
arendst reviewed Oct 29, 2024
View reviewed changes
tools/decode-status.py Outdated Show resolved Hide resolved
@arendst
Copy link
Owner

arendst commented Oct 29, 2024

fix unnecessary changes as you were told in your previous pr. Wastes our time.

@Jason2866 Jason2866 marked this pull request as draft October 30, 2024 21:51
@Jason2866 Jason2866 marked this pull request as ready for review November 2, 2024 14:26
@arendst arendst merged commit a35bb5a into arendst:development Nov 8, 2024
59 checks passed
josef109 pushed a commit to josef109/Tasmota that referenced this pull request Nov 10, 2024
@vtHydroponics @josef109
MS5837 functionality with BMP280 optional dependency (arendst#22376)
f868e9d 
* Finalized gain/integration adjustment trees

* Fixed the bugs

* works but polishing code

* need to debug pressure in bmp

* updated temp to change via setoption8 command from tasmota

* sensor table working, value reporting working, need to update dependency on sensor duality

* working

* updated file name for ms5837 xsns file

* final working with renamed for current updates (128->116)

* resolved PR comments for extra spaces, xi2c_96

* removed extra spaces, added unit for inches across languages

* added "Water depth" for languages

* removed inches as a unit from language files

* switched to centimeter units for SI consistency in Tasmota

* all variables showing in console and table; need to adjust offsets

* cm conversion properly reporting

* Sensor116 in console calibrates the sensor's pressure_offset variable

* removed pressure offset debugging lines

* removed unecessary commented items from old code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jason2866 Jason2866 Jason2866 left review comments

@arendst arendst arendst left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtHydroponics @arendst @Jason2866