Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extending Tasmota #2616

Closed
timwilky opened this issue May 3, 2018 · 3 comments
Closed

extending Tasmota #2616

timwilky opened this issue May 3, 2018 · 3 comments

Comments

@timwilky
Copy link

timwilky commented May 3, 2018

I have added LCD support to my Tasmota environment. But in doing so I had to add a new command to manage the I2C address.

The issue I experienced was that there is a conditional compilation whilst defining the kTasmotaCommands array.
#ifdef DEBUG_THEO
"|" D_CMND_EXCEPTION
#endif

Therefore if people make the logical mistake I made and add their new commands at the end of the TasmotaCammands enumeration and the kTasmotaCommands array, they become out of sync if the DEBUG_THEO flag is not in place!

@arendst
Copy link
Owner

arendst commented May 3, 2018

See branch development_display for a better solution.

@arendst
Copy link
Owner

arendst commented May 3, 2018

See #2557 too

@ascillato
Copy link
Contributor

Hi,

If your issue was solved, please, close it. Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants