Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MCP9808 i2c temperature sensor support #8594

Closed
m-hume opened this issue Jun 1, 2020 · 9 comments
Closed

Add MCP9808 i2c temperature sensor support #8594

m-hume opened this issue Jun 1, 2020 · 9 comments
Assignees
Labels
enhancement Type - Enhancement that will be worked on fixed Result - The work on the issue has ended

Comments

@m-hume
Copy link
Contributor

m-hume commented Jun 1, 2020

Have you looked for this feature in other issues and in the docs?
Yes
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.
MCP9808 not currently supported
Describe the solution you'd like
A clear and concise description of what you want to happen.
MCP9808 support added
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Use of different temperature sensors
Additional context
Add any other context or screenshots about the feature request here.
http://ww1.microchip.com/downloads/en/DeviceDoc/25095A.pdf
These little sensors are cheep, accurate and you can run up to 8 of them on one i2c bus
looking at others pull requests for adding i2c sensors there seems to quite a bit of code necessary to add one.
How difficult is it to add a new sensor?
Thanks
(Please, remember to close the issue when the problem has been addressed)

@sfromis
Copy link
Contributor

sfromis commented Jun 1, 2020

New sensors are usually added when someone interested volunteers to create a driver and submit a PR.

@m-hume
Copy link
Contributor Author

m-hume commented Jun 1, 2020

That's kind of what i was expecting. This is not really my in my area of expertise but i'll have a play with gitpod.io and see if i can come up with something

@ascillato2 ascillato2 added the feature request (devs?) Action - awaiting response from developers label Jun 1, 2020
@device111
Copy link
Contributor

@m-hume
please test this bin file and test what happens..:-)

It should support 8 sensors.

tasmota.zip

@m-hume
Copy link
Contributor Author

m-hume commented Jun 1, 2020

@device111 thank you!
Only tried with 2 sensors so far but it seems to work as described

192 168 99 148__(iPhone 6_7_8)

Is the bin missing anything or is it the standard build just with this sensor added?
I'm intrigued to see what was involved to get this working if you get chance to submit a pr
Thanks again for your time
m-hume

@ascillato2 ascillato2 added enhancement Type - Enhancement that will be worked on and removed feature request (devs?) Action - awaiting response from developers labels Jun 2, 2020
@device111
Copy link
Contributor

@m-hume
the PR is now in dev. Can you test it if all works? the resolution is set to 0.125 Celsius.
thanks!

@m-hume
Copy link
Contributor Author

m-hume commented Jun 3, 2020

@device111
I ran into a small issue regarding missing sensors
please see #8611

@ascillato2
Copy link
Collaborator

ascillato2 commented Jun 3, 2020

Closing this issue as the driver is merged and a PR with improvements is ready for review

Thanks 👍

@ascillato2 ascillato2 added the fixed Result - The work on the issue has ended label Jun 3, 2020
@m-hume
Copy link
Contributor Author

m-hume commented Jun 3, 2020

@device111
I don't want to sound ungrateful at all. Without your work getting the sensor implemented i'd still be scratching my head. Thank you for your hard work. It's appreciated 👍

@device111
Copy link
Contributor

@m-hume
greatest thanks go to Theo @arendst , who keeps the Show on running and always have a look above the big code in Tasmota.
Sometimes i think, he is never sleep...;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type - Enhancement that will be worked on fixed Result - The work on the issue has ended
Projects
None yet
Development

No branches or pull requests

4 participants