Problems with pull request #7231

[grizewald]

PROBLEM DESCRIPTION

Pull request #7231 which is currently in the development branch and release 8.3.1, breaks deep sleep sensors for Home Assistant by marking the sensor as "Unavailable" as soon as it sleeps. The way the changes in #7231 have been implemented means they cannot be turned off. (Which is far from the pull request's description of being optional).

A Will message is for use on abnormal disconnects only! The disconnect command is allowed to specify a reason for the disconnect and if sent with 4 as the status code, will cause the server to send the Will. As the PubSubClient library does not support parameters to the disconnect method, you could always just close the WiFi connection before restarting when the MQTT settings have changed rather than cleanly disconnecting. This would have the same effect as disconnecting with status code 4.
Unconditionally changing the way the MQTT protocol works at the level of the PubSubClient library is a bad way to solve the original problem.

REQUESTED INFORMATION

Make sure your have performed every step and checked the applicable boxes before submitting your issue. Thank you!

• Read the Contributing Guide and Policy and the Code of Conduct
• Searched the problem in issues
• Searched the problem in the docs
• Searched the problem in the forum
• Searched the problem in the chat
• Device used (e.g., Sonoff Basic): Wemos D1
• Tasmota binary firmware version number used: 3.8.1 + 3.8.1.2
  • Pre-compiled
  • Self-compiled
    • IDE / Compiler used: Arduino IDE 1.8.12
• Flashing tools used: Arduino / esptool
• Provide the output of command: Backlog Template; Module; GPIO 255:

  Configuration output here:

N/A

• If using rules, provide the output of this command: Backlog Rule1; Rule2; Rule3:

  Rules output here:

• Provide the output of this command: Status 0:

  STATUS 0 output here:

N/A

• Provide the output of the Console log output when you experience your issue; if applicable:
  (Please use weblog 4 for more debug information)

  Console output here:

N/A

TO REPRODUCE

Steps to reproduce the behavior:

Connect a sensor device using deep sleep. Wait until it sleeps.

EXPECTED BEHAVIOUR

A clear and concise description of what you expected to happen.
Sensor remains "Online" as far as Home Assistant is concerned.

SCREENSHOTS

If applicable, add screenshots to help explain your problem.

ADDITIONAL CONTEXT

Add any other context about the problem here.

(Please, remember to close the issue when the problem has been addressed)

[ascillato]

Duplicated Request

See the open issue where this is being discussed and worked. #8655

[effelle]

Let's discuss on the other topic then.