Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Writing] Park writing review #2

Open
yardasol opened this issue Feb 25, 2025 · 1 comment
Open

[Writing] Park writing review #2

yardasol opened this issue Feb 25, 2025 · 1 comment
Assignees
Labels
Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:1-Critical This is the highest priority (i.e. it is blocking other work or facing a deadline). Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Feature New feature or feature request

Comments

@yardasol
Copy link
Collaborator

Review Details

Intended Venue: This is the initial submission for my talk for SciPy 2025

Link to pdf: The initial submission is text entry into a form. I have stored this in a markdown document here.

Options for receiving feedback: Please provide written feedback.

Anticipated response time to feedback: within the next 2 days (the deadline for submission is February 26)

Have you applied the Writing Checklist?: Yes

What is the pre-discussed timeline?

The deadline for submission is February 26.

Previous reviews.

Nathan Ryan performed a review.

Additional context

I know this is very short notice, but the SciPy Initial Submissions are very short, so a review should not take much time at all.

How can this issue be closed?

This issue can be closed when feedback has been incorporated or discussed.

@yardasol yardasol added Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:1-Critical This is the highest priority (i.e. it is blocking other work or facing a deadline). Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Feature New feature or feature request labels Feb 25, 2025
@bryanjp05
Copy link

Abstract:

  • First sentence can be changed to this for better flow: "OpenMC is an open-source, community-developed software for neutron transport simulations, featuring a depletion module for fuel burnup calculations in nuclear reactors."

  • "In a scenario where the material composition does not appreciably change, or we need reasonably accurate and low cost depletion, the transport solution may only need to be run once; the same cross sections used for the entire depletion calculation." I think using a transition word here would be helpful such as: "However, in scenarios where material composition changes are minimal or depletions require lower cost, the transport solution may only need to be ran once, using the same cross sections throughout the depletion process."

Description:

  • "The fission reaction causes the nucleus to break apart, releasing both energy and new nuclides, many of which are radioactive isotopes of smaller elements. This process is referred to as depletion or burnup." Can combine these sentences into: "This fission reaction releases energy and new nuclides, including radioactive isotopes, in a process referred to as depletion or burnup."

  • "We model this process to design and license new reactors as depletion can effect performance and determines when the fuel must be shuffled or replaced" -> "We model this process to design and license new reactors because it determines when the fuel must be shuffled or replaced."

  • "The typical approach to modeling depletion requires solving the neutron transport equation to obtain reaction rates which govern the material composition at the next time step. This process is repeated iteratively (transport-coupled depletion)." Can combine into one sentence as: "The typical approach to modeling depletion requires solving the neutron transport equation at each time step in a process known as transport-coupled depletion."

  • "... (transport-independent depletion). Instead, the transport equation is solved once, and multigroup cross sections and fluxes are obtained from this solution." -> "Instead, they use transport-independent depletion, meaning they solve the transport equation once, and multigroup cross sections and fluxes are obtained from this solution."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:1-Critical This is the highest priority (i.e. it is blocking other work or facing a deadline). Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Feature New feature or feature request
Projects
None yet
Development

No branches or pull requests

2 participants