-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid Hard-Coded variables #60
Comments
closed by #47 |
I think that would be best. |
Below are a list of the lines I found that are hard-coded in the scripts folder's files. analysis.py |
Great work @RhysMacMillan, I look forward to reviewing you PR here. I think it would be best if you divide it up by script (some of the scripts with a few changes can be grouped together, but try to keep your PRs small so they are easy to review and faster to implement), keep in mind how the changes will affect the tests! When you make a PR, there should be corresponding changes to the tests such that they still work as designed. |
If you have ideas or questions about what a variable does and you aren't sure, feel free to ask here so people can refer back to the discussion in the future if they have to. |
I’ve changed all of the instances of the start year being 1965 except for in |
As noted in #162, there's some work on |
All scripts in the scripts folder need to be reviewed and to be refactored for clarity.
This issue can be closed when all scripts have been refactored to avoid hard-coding variables without leaving any trace of the source or meaning of the data. No bare numbers, please. Filenames and paths that must be stored may need to be hardcoded, but should be organized and well-named.
The text was updated successfully, but these errors were encountered: