-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve project setup #337
Conversation
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
======================================
Coverage 99.2% 99.2%
======================================
Files 11 11
Lines 884 884
Branches 93 93
======================================
Hits 877 877
Misses 7 7 Continue to review full report at Codecov.
|
setup.py
Outdated
if not strtobool(os.environ.get("AIOCACHE_MEMCACHED", "yes")): | ||
print("Installing without aiomcache") | ||
install_requires.remove(aiomcache) | ||
requirements = load_requirements('requirements.txt') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention of #329 is to remove the requirements file. I'm against using fixed dependencies for install_requires
because its like saying aiocache only works with those specific aioredis and aiomcache versions and its not true.
The idea is to remove the requirements file and specify dependencies only in the setup file.
In the end, the setup.py file should look like:
install_requires = []
extras_require = {
'redis': ['aioredis>=0.3.3,<1'],
'memcached': ['aiomcache>=0.5.2']
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks! I'm keeping #329 open because I want to move dev dependencies into setup too. |
@argaen setuptools have a section to define development/tests dependencies? 🤔 |
It has for test dependencies but my intention is to use |
Fix #329