Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve project setup #337

Merged
merged 1 commit into from
Sep 29, 2017
Merged

improve project setup #337

merged 1 commit into from
Sep 29, 2017

Conversation

jairhenrique
Copy link
Contributor

Fix #329

@codecov-io
Copy link

codecov-io commented Sep 28, 2017

Codecov Report

Merging #337 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #337   +/-   ##
======================================
  Coverage    99.2%   99.2%           
======================================
  Files          11      11           
  Lines         884     884           
  Branches       93      93           
======================================
  Hits          877     877           
  Misses          7       7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e1278f...533b252. Read the comment docs.

setup.py Outdated
if not strtobool(os.environ.get("AIOCACHE_MEMCACHED", "yes")):
print("Installing without aiomcache")
install_requires.remove(aiomcache)
requirements = load_requirements('requirements.txt')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention of #329 is to remove the requirements file. I'm against using fixed dependencies for install_requires because its like saying aiocache only works with those specific aioredis and aiomcache versions and its not true.

The idea is to remove the requirements file and specify dependencies only in the setup file.

In the end, the setup.py file should look like:

install_requires = []
extras_require = {
   'redis': ['aioredis>=0.3.3,<1'],
   'memcached': ['aiomcache>=0.5.2']
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@argaen argaen merged commit a46980c into aio-libs:master Sep 29, 2017
@argaen
Copy link
Member

argaen commented Sep 29, 2017

Thanks!

I'm keeping #329 open because I want to move dev dependencies into setup too.

@jairhenrique jairhenrique deleted the improve-setup branch October 3, 2017 01:25
@jairhenrique
Copy link
Contributor Author

@argaen setuptools have a section to define development/tests dependencies? 🤔

@argaen
Copy link
Member

argaen commented Oct 3, 2017

It has for test dependencies but my intention is to use extras_require as Flask does: https://github.com/pallets/flask/blob/master/setup.py#L79.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants