Skip to content
This repository has been archived by the owner on Jul 15, 2024. It is now read-only.

Intermittent E2E test failure on TestSimpleGitFilesPreserveResourcesOnDeletion #229

Merged
merged 3 commits into from
May 12, 2021
Merged

Intermittent E2E test failure on TestSimpleGitFilesPreserveResourcesOnDeletion #229

merged 3 commits into from
May 12, 2021

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented May 7, 2021

This PR:

  • Updates the documentation to correctly describe the expected behaviour
  • Shortens the test case so that it tests just what is required
  • Ensures that, after delete, the test case is testing that for the presence of a Pod, rather than the Application itself.
  • Some additional E2E test tweaks to improve reliability.

Fixes #227

@jgwest jgwest force-pushed the preserve-on-delete-e2e-227 branch from bace29a to 4449c99 Compare May 10, 2021 15:19
@jgwest jgwest force-pushed the preserve-on-delete-e2e-227 branch from 442df03 to 1bb26ad Compare May 10, 2021 20:27
@jgwest jgwest marked this pull request as ready for review May 10, 2021 20:56
@jgwest jgwest requested a review from wtam2018 May 10, 2021 20:57
wtam2018
wtam2018 approved these changes May 11, 2021
View reviewed changes
Copy link
Collaborator

@wtam2018 wtam2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@jgwest thanks!

@jgwest jgwest merged commit 705dddd into argoproj:master May 12, 2021
@jgwest jgwest deleted the preserve-on-delete-e2e-227 branch May 12, 2021 11:06
@jgwest jgwest added this to the Milestone 2 milestone May 12, 2021
@jgwest jgwest mentioned this pull request Jul 19, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wtam2018 wtam2018 wtam2018 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

Intermittent E2E test failure on TestSimpleGitFilesPreserveResourcesOnDeletion
2 participants
@jgwest @wtam2018