This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
Issue #170 is not solved when using server, only when using name for destination #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtam2018
approved these changes
Jul 8, 2021
…ame for destination
…ame for destination
…ame for destination
…ame for destination
jgwest
force-pushed
the
validate-destination-220
branch
from
e34c409
to
cc60bf0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same fix as I made on Argo CD here but since we support older Argo CDs in ApplicationSet controller, it needs to be made here as well.
Fixes #220