This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
feat: allow any key/value pair in list generator #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jgwest PTAL the PR is ready for review |
jgwest
suggested changes
Jul 12, 2021
There was a problem hiding this comment.
Looks great, I'm really looking forward to this feature 😄 . I've added a few quick code tweak comments below, and one more thing: can you update the documentation under docs/Generators-List.md? Just need to change it to say that the user can now specify any key/value field they want (as long as they are strings), rather than just cluster and url.
I'm also going to do some quick manual testing to make sure it works as expected, I'll let you know if find any issues (but I'm not expecting any, the PR looks excellent)
jgwest
approved these changes
Jul 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow any key/value pair in list generator supporting backward compatibility for
valuesfieldFixes: #162
Signed-off : Ishita Sequeira