Skip to content
This repository has been archived by the owner on Jul 15, 2024. It is now read-only.

Investigate Argo CD deletion failure messages when running ApplicationSet E2E tests in on-cluster configuration #392

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Investigate Argo CD deletion failure messages when running ApplicationSet E2E tests in on-cluster configuration #392

merged 1 commit into from
Nov 5, 2021

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Oct 21, 2021

Fixes #304

This PR:

  • Fix issue when running E2E tests with on-cluster images would fail, due to invalid cluster credentials (we are using fake username/password, which works locally, but doesn't work on cluster)
  • Fixes issue where ApplicationController didn't have RBAC needed to access PlacementRule during E2E tests
  • Add additional checks to 'EnsureCleanSlate' to clean up old tests.
  • Renames some of the tests to their proper name

@jgwest jgwest marked this pull request as ready for review October 25, 2021 16:20
@jgwest jgwest requested a review from wtam2018 October 25, 2021 16:21
wtam2018
wtam2018 approved these changes Nov 5, 2021
View reviewed changes
Copy link
Collaborator

@wtam2018 wtam2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks @jgwest

@wtam2018 wtam2018 merged commit aca6624 into argoproj:master Nov 5, 2021
@jgwest jgwest mentioned this pull request Dec 7, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wtam2018 wtam2018 wtam2018 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jgwest @wtam2018