Skip to content
This repository has been archived by the owner on Jul 15, 2024. It is now read-only.

Corrected wrong info about path and path.basename #412

Merged
merged 3 commits into from
Nov 16, 2021

Conversation

olvesh
Copy link
Contributor

@olvesh olvesh commented Nov 11, 2021

Corrected wrong info in doc about Git Generator: Files fixed #407 by copying documentation from #258 (comment) as suggested in #407 (comment)

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2021

CLA assistant check
All committers have signed the CLA.

docs/Generators-Git.md Outdated Show resolved Hide resolved
Corrected wrong info in doc about _Git Generator: Files_  fixed argoproj#407   by copying documentation from argoproj#258 (comment) as suggested in argoproj#407 (comment)
Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @olvesh! I merged this with the other PR targeting this file, and tweaked the formatting.

@jgwest jgwest merged commit 11f1fe8 into argoproj:master Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about path parameter in Git Generator: Files
4 participants