This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
Feat/support webhook for pull request generator #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed so that the same annotation can be used for all generators. There is no reason to set annotations individually, since annotations will result in refreshes for all generators in the ApplicationSet.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I wrote in #366 (comment), the pull request generator also supports webhooks for quick synchronization. I've added webhook support.
I also refactored some of the code because it was not good to simply add it. I also changed the annotations from the git generator-specific annotations to the common annotations, as it seemed to be a good idea to make the annotations common to all generators.
If you have any problems with this change, please comment and I will change it.