Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appset controller deployment doesn't respect .spec.image & .spec.version fields in ArgoCD CR #1517

Closed
svghadi opened this issue Aug 22, 2024 · 0 comments · Fixed by #1523
Closed
Labels
bug Something isn't working

Comments

@svghadi
Copy link
Collaborator

svghadi commented Aug 22, 2024

Describe the bug
Operator supports overriding default image for Argo CD components(server, repo-server, application-controller, applicationset-controller, notifications-controller) using .spec.image & .spec.version fields in ArgoCD CR. However, the applicationset-controller deployment doesn't respect this configuration. The image value is not reflected in the deployment.

To Reproduce
Create ArgoCD CR

apiVersion: argoproj.io/v1beta1
kind: ArgoCD
metadata:
  name: example
spec:
  image: quay.io/argoproj/argocd
  version: v2.12.0
  applicationSet:
    enabled: true

Expected behavior
The applicationset-controller deployment should use image specified in .spec.image & .spec.version fields from ArgoCD CR.

Actual behavior
The image in applicationset-controller deployment point to default value set by the operator.

Additional context
ApplicationSet controller image can be configured using .spec.applicationSet.image & .spec.applicationSet.version fields of the ArgoCD CR. I believe, the operator should proritize the image configuration in following order

default value < .spec.image < .spec.applicationSet.image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant