Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation Error when creating a RetryStrategy #552

Closed
jplikesbikes opened this issue Apr 4, 2023 · 2 comments · Fixed by #565
Closed

Validation Error when creating a RetryStrategy #552

jplikesbikes opened this issue Apr 4, 2023 · 2 comments · Fixed by #565
Assignees
Labels
note:good-first-issue A good first issue to get started with type:bug A general bug

Comments

@jplikesbikes
Copy link
Contributor

I'm not terribly familiar with Pydantic, but I think there is an error with the RetryStrategy model

from hera.workflows import RetryStrategy

if __name__ == "__main__":
    RetryStrategy(limit=3)

The above fails with

pydantic.error_wrappers.ValidationError: 2 validation errors for RetryStrategy
limit
  value is not a valid integer (type=type_error.integer)
limit
  str type expected (type=type_error.str)
@sambhav sambhav added type:bug A general bug note:good-first-issue A good first issue to get started with labels Apr 5, 2023
@lakhanjindam
Copy link
Contributor

hey i can pick this up, if no one is working, can you assign to me ?

@dmerrick
Copy link
Contributor

dmerrick commented Apr 6, 2023

I am also experiencing this issue

@flaviuvadan flaviuvadan linked a pull request Apr 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note:good-first-issue A good first issue to get started with type:bug A general bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants