Skip to content
This repository has been archived by the owner on Jul 15, 2024. It is now read-only.

Add 'VERSION' file contents and latest commit ID to controller startup #169

Closed
jgwest opened this issue Mar 24, 2021 · 0 comments · Fixed by #241
Closed

Add 'VERSION' file contents and latest commit ID to controller startup #169

jgwest opened this issue Mar 24, 2021 · 0 comments · Fixed by #241
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
0.2.0

Comments

@jgwest
Copy link
Member

jgwest commented Mar 24, 2021

For the purposes of problem determination and debugging, it would be beneficial if the controller pod logged the specific version of the ApplicationSet controller that was running. We can pull these values at build time from VERSION and git.

See Argo CD's common/version.go and the Argo CD Makefile for an example of this.
@jgwest jgwest added the enhancement New feature or request label Mar 24, 2021
@jgwest jgwest changed the title Add VERSION contents and latest commit id to controller startup Add 'VERSION' file contents and latest commit ID to controller startup Mar 25, 2021
@jgwest jgwest added the help wanted Extra attention is needed label May 17, 2021
@chetan-rns chetan-rns mentioned this issue May 24, 2021
Merged
@jgwest jgwest added this to the Milestone 2 milestone Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Log appset version during controller startup chetan-rns/applicationset
1 participant
@jgwest