No environment vars when running helm generate

[timstoop]

Hi,

I read on https://github.com/argoproj/argo-cd/blob/master/docs/user-guide/build-environment.md that some ARGOCD environment vars should be available for Helm. However, when I change the /usr/local/bin/helm with a custom script that first logs all the environment variables and then runs helm with the given parameters, I do not get the environment variables listed on the build-environment page when it creates the initial templates. Printing the entire env and the command to the log file gives me a long list of the env variabled added by Kubernetes, but not the ones mentioned on the aforementioned page. Seems like they are not available during template creation or are they passed in a different way?

My script:

#!/bin/bash
echo `env` >> /tmp/helm.out
echo "$0 $@" >> /tmp/helm.out
/usr/bin/helm $@

Example output:

KUBERNETES_SERVICE_PORT_HTTPS=443 ARGOCD_DEX_SERVER_SERVICE_PORT=5556 ARGOCD_DEX_SERVER_PORT_5557_TCP_PORT=5557 ARGOCD_SERVER_SERVICE_PORT_HTTPS=443 KUBERNETES_SERVICE_PORT=443 ARGOCD_SERVER_PORT_80_TCP_PORT=80 ARGOCD_SERVER_PORT_80_TCP_A
DDR=10.111.187.44 ARGOCD_DEX_SERVER_SERVICE_PORT_METRICS=5558 ARGOCD_METRICS_PORT_8082_TCP_ADDR=10.99.136.234 HOSTNAME=argocd-repo-server-64657947bf-pnv8z ARGOCD_METRICS_SERVICE_HOST=10.99.136.234 ARGOCD_DEX_SERVER_SERVICE_PORT_GRPC=5557 
XDG_DATA_HOME=/tmp/helm320830597/data ARGOCD_SERVER_METRICS_PORT=tcp://10.98.241.96:8083 ARGOCD_REPO_SERVER_PORT_8081_TCP=tcp://10.98.215.213:8081 XDG_CONFIG_HOME=/tmp/helm320830597/config ARGOCD_DEX_SERVER_PORT_5558_TCP_ADDR=10.101.6.32 
ARGOCD_REDIS_SERVICE_PORT=6379 ARGOCD_METRICS_PORT=tcp://10.99.136.234:8082 ARGOCD_REDIS_SERVICE_PORT_TCP_REDIS=6379 ARGOCD_REPO_SERVER_PORT_8081_TCP_ADDR=10.98.215.213 PWD=/tmp/helm760841627/botkube ARGOCD_REDIS_PORT_6379_TCP_ADDR=10.101
.219.141 ARGOCD_METRICS_PORT_8082_TCP_PROTO=tcp ARGOCD_REDIS_PORT_6379_TCP=tcp://10.101.219.141:6379 ARGOCD_SERVER_SERVICE_PORT_HTTP=80 ARGOCD_SERVER_METRICS_PORT_8083_TCP_PROTO=tcp KUSTOMIZE_VERSION=3.9.1 ARGOCD_SERVER_PORT_80_TCP=tcp://
10.111.187.44:80 ARGOCD_DEX_SERVER_PORT_5556_TCP=tcp://10.101.6.32:5556 ARGOCD_METRICS_PORT_8082_TCP=tcp://10.99.136.234:8082 HOME=/home/argocd ARGOCD_DEX_SERVER_PORT_5558_TCP_PROTO=tcp KUBERNETES_PORT_443_TCP=tcp://10.96.0.1:443 ARGOCD_S
ERVER_METRICS_PORT_8083_TCP_PORT=8083 ARGOCD_REPO_SERVER_PORT_8084_TCP_PROTO=tcp PIP_EXTRA_INDEX_URL=https://pypi.kumina.net/simple/ ARGOCD_DEX_SERVER_PORT_5556_TCP_PROTO=tcp ARGOCD_REDIS_SERVICE_HOST=10.101.219.141 ARGOCD_REPO_SERVER_POR
T_8084_TCP_PORT=8084 ARGOCD_REPO_SERVER_PORT=tcp://10.98.215.213:8081 XDG_CACHE_HOME=/tmp/helm320830597/cache ARGOCD_REDIS_PORT_6379_TCP_PORT=6379 ARGOCD_REPO_SERVER_SERVICE_PORT_METRICS=8084 ARGOCD_SERVER_PORT_443_TCP=tcp://10.111.187.44
:443 ARGOCD_SERVER_METRICS_SERVICE_PORT=8083 ARGOCD_SERVER_PORT_80_TCP_PROTO=tcp ARGOCD_SERVER_SERVICE_HOST=10.111.187.44 TERM=xterm ARGOCD_REPO_SERVER_SERVICE_HOST=10.98.215.213 ARGOCD_REPO_SERVER_PORT_8084_TCP=tcp://10.98.215.213:8084 A
RGOCD_DEX_SERVER_PORT_5557_TCP_ADDR=10.101.6.32 USER=argocd ARGOCD_SERVER_SERVICE_PORT=80 ARGOCD_SERVER_PORT_443_TCP_PORT=443 ARGOCD_REPO_SERVER_PORT_8084_TCP_ADDR=10.98.215.213 ARGOCD_METRICS_PORT_8082_TCP_PORT=8082 ARGOCD_SERVER_METRICS
_SERVICE_PORT_METRICS=8083 SHLVL=0 ARGOCD_DEX_SERVER_PORT_5557_TCP_PROTO=tcp HELM_HOME=/tmp/helm320830597 ARGOCD_DEX_SERVER_PORT_5558_TCP_PORT=5558 KUBERNETES_PORT_443_TCP_PROTO=tcp ARGOCD_DEX_SERVER_PORT_5557_TCP=tcp://10.101.6.32:5557 K
UBERNETES_PORT_443_TCP_ADDR=10.96.0.1 ARGOCD_REDIS_PORT=tcp://10.101.219.141:6379 ARGOCD_METRICS_SERVICE_PORT=8082 ARGOCD_SERVER_METRICS_PORT_8083_TCP_ADDR=10.98.241.96 ARGOCD_SERVER_METRICS_PORT_8083_TCP=tcp://10.98.241.96:8083 ARGOCD_RE
PO_SERVER_SERVICE_PORT=8081 KUBERNETES_SERVICE_HOST=10.96.0.1 KUBERNETES_PORT=tcp://10.96.0.1:443 KUBERNETES_PORT_443_TCP_PORT=443 ARGOCD_SERVER_METRICS_SERVICE_HOST=10.98.241.96 ARGOCD_DEX_SERVER_PORT_5556_TCP_PORT=5556 ARGOCD_REPO_SERVE
R_SERVICE_PORT_SERVER=8081 PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin ARGOCD_DEX_SERVER_PORT_5556_TCP_ADDR=10.101.6.32 ARGOCD_SERVER_PORT_443_TCP_ADDR=10.111.187.44 ARGOCD_DEX_SERVER_SERVICE_HOST=10.101.6.32 ARGOCD_
METRICS_SERVICE_PORT_METRICS=8082 ARGOCD_REPO_SERVER_PORT_8081_TCP_PORT=8081 ARGOCD_DEX_SERVER_SERVICE_PORT_HTTP=5556 ARGOCD_REDIS_PORT_6379_TCP_PROTO=tcp DEBIAN_FRONTEND=noninteractive ARGOCD_REPO_SERVER_PORT_8081_TCP_PROTO=tcp ARGOCD_SE
RVER_PORT_443_TCP_PROTO=tcp ARGOCD_DEX_SERVER_PORT_5558_TCP=tcp://10.101.6.32:5558 ARGOCD_SERVER_PORT=tcp://10.111.187.44:80 ARGOCD_DEX_SERVER_PORT=tcp://10.101.6.32:5556 _=/usr/bin/env
/usr/local/bin/helm template . --name-template botkube --namespace botkube --api-versions v1 --api-versions apiregistration.k8s.io/v1 --api-versions apiregistration.k8s.io/v1beta1 --api-versions apps/v1 --api-versions events.k8s.io/v1 --a
pi-versions events.k8s.io/v1beta1 --api-versions authentication.k8s.io/v1 --api-versions authentication.k8s.io/v1beta1 --api-versions authorization.k8s.io/v1 --api-versions authorization.k8s.io/v1beta1 --api-versions autoscaling/v1 --api-
versions autoscaling/v2beta1 --api-versions autoscaling/v2beta2 --api-versions batch/v1 --api-versions batch/v1beta1 --api-versions certificates.k8s.io/v1 --api-versions certificates.k8s.io/v1beta1 --api-versions networking.k8s.io/v1 --ap
i-versions networking.k8s.io/v1beta1 --api-versions extensions/v1beta1 --api-versions policy/v1beta1 --api-versions rbac.authorization.k8s.io/v1 --api-versions rbac.authorization.k8s.io/v1beta1 --api-versions storage.k8s.io/v1 --api-versi
ons storage.k8s.io/v1beta1 --api-versions admissionregistration.k8s.io/v1 --api-versions admissionregistration.k8s.io/v1beta1 --api-versions apiextensions.k8s.io/v1 --api-versions apiextensions.k8s.io/v1beta1 --api-versions scheduling.k8s
.io/v1 --api-versions scheduling.k8s.io/v1beta1 --api-versions coordination.k8s.io/v1 --api-versions coordination.k8s.io/v1beta1 --api-versions node.k8s.io/v1 --api-versions node.k8s.io/v1beta1 --api-versions discovery.k8s.io/v1beta1 --ap
i-versions flowcontrol.apiserver.k8s.io/v1beta1 --api-versions argoproj.io/v1alpha1 --include-crds

I'd like to hook in some additional logic before the helm evocation, for which I am depending on those environment variables to determine which application is being templated, so I was expecting/hoping those build variables would be available? Am I misunderstanding something?

[mayzhang2000]

Here is the code that these environment vars are used.
https://github.com/argoproj/argo-cd/blob/master/reposerver/repository/repository.go#L584-L604

Issue is opened #5429.