Delete CRD should give an indication of the number and list of items to be deleted

[jsoref]

If you are trying to resolve an environment-specific issue or have a one-off question about the edge case that does not require a feature then please consider asking a question in argocd slack channel.

Checklist:

• I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• I've included steps to reproduce the bug.
• I've pasted the output of argocd version.

Describe the bug

I tried upgrading an experimental instance's sealed-secret deployment and received a spec discrepancy in the sealed-secret CRD. I decided to delete the resource.

The end result is that all of my sealed-secrets (and the secrets they owned) were deleted.

To Reproduce

1. Install sealed-secrets (1.10.3) using helm (via argo)

   dependencies:
   - name: sealed-secrets
     version: 1.10.3
     repository: https://charts.helm.sh/stable/

2. Properly seal and install some secrets
3. Upgrade sealed-secrets (1.14.1-r1) using helm (via argo)

   dependencies:
   - name: sealed-secrets
     version: 1.14.1-r1
     repository: https://bitnami-labs.github.io/sealed-secrets/

4. See a warning about the CRD not matching
5. Decide to delete the CRD
6. Get the generic type the name item to delete the CRD
7. Enter the name of the resource and delete it

Expected behavior

While ArgoCD may not know about all objects in the cluster, as it will know about many of them, it should be able to tell the user how many objects of the type managed by the CRD will be destroyed. And ideally have a way to show them.

Screenshots

Version

{
    "Version": "v1.9.0+bb15a49",
    "BuildDate": "2021-02-06T01:06:52Z",
    "GitCommit": "bb15a4996e327fb27ad91f3f6fa24f831f7754e0",
    "GitTreeState": "clean",
    "GoVersion": "go1.14.12",
    "Compiler": "gc",
    "Platform": "linux/amd64",
    "KsonnetVersion": "v0.13.1",
    "KustomizeVersion": "v3.8.1 2020-07-16T00:58:46Z",
    "HelmVersion": "v3.5.1+g32c2223",
    "KubectlVersion": "v0.20.1",
    "JsonnetVersion": "v0.17.0"
}

Logs

Paste any relevant application logs here.

[rbreeze]

Are you saying you deleted the actual CRD itself? Or a single sealed secret?

If you deleted the sealed secret CRD from the cluster, then it's expected that all sealed secret resources would be deleted. This is expected behavior and beyond the scope of Argo CD to warn about this

[jsoref]

The actual CRD.

Oddly, the CRD didn't actually get deleted (I suspect something broke before it finished...), I lost all my SealedSecrets, but was able to just use kubectl apply to put enough back to unbreak ArgoCD and they it was able to heal.

I'm not precisely asking ArgoCD to protect me from shooting myself in my toe. Mostly hoping that ArgoCD could tell me how many toes I'm going to lose or that I'm going to lose my whole torso.

The problem with "are you sure you want to do X" dialogs is that, yes, if a user tries to do X, they do think they're trying to do X. What users need in order to be able to confirm that they actually want to do X is to have an explanation of the consequences of doing X actually are. In the case of deleting a CRD, to someone using a GUI, it isn't obvious that it'll delete the associated resources (sure, someone well-versed in k8s may know this, but not everyone will).

Being able to see/know which cascades will happen is what's important to making an informed decision.