Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement in multi source repo and notification #13188

Open
Shubham1406220 opened this issue Apr 11, 2023 · 3 comments
Open

Enhancement in multi source repo and notification #13188

Shubham1406220 opened this issue Apr 11, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Shubham1406220
Copy link

Shubham1406220 commented Apr 11, 2023

Hello,

I have setup the multiple source repo setup in applicationset. When notification is triggered the revision section is blank but it is visible when i use a single repo in applicationset. Have i missed any configuration to be setup or it is the limitation of multi source repo setup.

I also want to show the image tag of the application got deployed in notification for the same setup. Is it possible ??

#13177 (comment)

@Shubham1406220 Shubham1406220 added the enhancement New feature or request label Apr 11, 2023
@adrianmiron
Copy link

I have the same issue, probably linked to the fact that we have multiple revisions for multiple sources and the app controller doesn't know which one to pick, looking forward to a fix.

@chkp-zivhada
Copy link

chkp-zivhada commented Feb 14, 2024

@Shubham1406220 I don't receive slack notification while application values.yaml file changes ( although Argo applies the change).
This is my ApplicationSet:

apiVersion: argoproj.io/v1alpha1
kind: ApplicationSet
metadata:
  name: main
  namespace: argocd
  finalizers:
    - resources-finalizer.argocd.argoproj.io
spec:
  generators:
  - list:
      elements:
        - appName: grafana
          namespace: monitoring
          repoURL: https://grafana.github.io/helm-charts
          targetRevision: 7.3.0
  template:
    metadata:
      name: "{{appName}}"
      namespace: argocd
      annotations:
        argocd.argoproj.io/manifest-generate-paths: ".;.."
        notifications.argoproj.io/subscribe.on-deployed.slack: argocd-alerts
        notifications.argoproj.io/subscribe.on-sync-failed.slack: argocd-alerts
        notifications.argoproj.io/subscribe.on-sync-succeeded.slack: argocd-alerts
    spec:
      project: default
      sources:
      - repoURL: "{{repoURL}}"
        chart: "{{appName}}"
        targetRevision: "{{targetRevision}}"
        helm:
          valueFiles:
          - "$values/eks/argocd/charts/{{appName}}/values.yaml"
      - repoURL: git@github.com:xxx/devops.git
        targetRevision: eks-new-infra-test
        ref: values
      destination:
        name: in-cluster
        namespace: "{{namespace}}"
      syncPolicy:
        automated:
          prune: true
          selfHeal: true
        syncOptions:
          - CreateNamespace=true

while deploying the application directly using kind:Application, the slack notification sent successfully.
Am I missing something here?

@ebarped
Copy link

ebarped commented Dec 13, 2024

This issue is somehow related to #19766, because can be fixed by modifying the templates defined in the catalog.

The fix should be close to the changes made in #20237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants