Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applications in any namespace: namespaced Application does not count towards an AppProject's application count. #13349

Open
torfjor opened this issue Apr 25, 2023 · 2 comments
Open

Applications in any namespace: namespaced Application does not count towards an AppProject's application count. #13349

torfjor opened this issue Apr 25, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@torfjor
Copy link
Contributor

torfjor commented Apr 25, 2023

See https://github.com/argoproj/argo-cd/blob/master/controller/appcontroller.go#L915

This makes cascading deletion of Applications that reference the AppProject fail:
Screenshot 2023-04-25 at 20 42 14

The AppProject is deleted before the Application even if the AppProject has the resource finalizer attached.
@torfjor torfjor added the bug Something isn't working label Apr 25, 2023
@torfjor
Copy link
Contributor Author

torfjor commented Apr 25, 2023

For anyone else stumbling upon this issue: you can give your AppProjects a lower sync-wave value than your Applications.

@mjgallag
Copy link

@torfjor thank you for logging this, 3rd result when I googled "appproject finalizer not working", saved me a lot of debugging!

@mjgallag mjgallag mentioned this issue May 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjgallag @torfjor