FullNameByRepoURL util function doesn't work for gitlab nested projects urls

[riteshnanda09]

argocd version : v2.7.0.

Describe the bug

When using FullNameByRepoURL function in notification template to get the repo full name this returns only first two nesting. Now in case of gitlab repo url where gitlab allows to have multiple nesting by projects in repos .

path: /projects/{{call .repo.FullNameByRepoURL .app.spec.source.repoURL}}/statuses/{{.app.status.operationState.operation.sync.revision}}

eg.
https://gitlab.example.com/project1/project2/project3/argocd-demo.git

This returns project1/project2 but expected is to get project1/project2/project3/argocd-demo

Looking at code here https://github.com/argoproj/argo-cd/blob/master/util/notification/expression/repo/repo.go#L73

func FullNameByRepoURL(rawURL string) string {
	parsed, err := giturls.Parse(rawURL)
	if err != nil {
		panic(err)
	}

	path := gitSuffix.ReplaceAllString(parsed.Path, "")
	if pathParts := text.SplitRemoveEmpty(path, "/"); len(pathParts) >= 2 {
		return strings.Join(pathParts[:2], "/")
	}

	return path
}

this will always return first 2 elements. Not sure on the history and motivation for this , but for me the fix would removing the condition checking for greater than.

[riteshnanda09]

Also looks If trying to use notification webhook for gitlab commit api , gitlab requires the path to be sent as url encoded and there is no easy way to generate that with the use of notification functions or templating , has anyone successfully tried integration with gitlab commit status api ?

[aslafy-z]

I opened #16234 to address this issue.

@riteshnanda09 If you're not using any special characters to your repository name, you can use call .strings.ReplaceAll .app.spec.source.repoURL "/" "%2F". If so, you can still replace additional characters the same way.

[aslafy-z]

As @janschumann suggested, both text/template and html/template have default apis to urlencode :

urlquery is available for text/template: https://pkg.go.dev/text/template#hdr-Functions

urlescaper is available for html/template:
https://pkg.go.dev/html/template#hdr-Contexts

I'm not sure which one ArgoCD uses in this context.

[janschumann]

As @janschumann suggested, both text/template and html/template have default apis to urlencode :

urlquery is available for text/template: https://pkg.go.dev/text/template#hdr-Functions

urlescaper is available for html/template: https://pkg.go.dev/html/template#hdr-Contexts

I'm not sure which one ArgoCD uses in this context.

Please consider #16343. Instead of adding the function to the repo package, it could also be added to the strings package. Would that make sense?

I recognised that there are no tests in the repo package. That is due to the argued.Service dependency, correct? Can't that be mocked for the tests?

[aslafy-z]

@janschumann please check https://go.dev/play/p/eGKR5wfI-UN, these functions are already available as builtins in the template context. Can you give a try within argocd-notifications?

[nuno-silva]

confirming ArgoCD v2.10.4 is still affected by this issue