Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll-related Issues with Pod Logs Viewer #14387

Closed
3 tasks done
Asuforce opened this issue Jul 7, 2023 · 6 comments
Closed
3 tasks done

Scroll-related Issues with Pod Logs Viewer #14387

Asuforce opened this issue Jul 7, 2023 · 6 comments
Assignees
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements

Comments

@Asuforce
Copy link
Contributor

Asuforce commented Jul 7, 2023

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

After upgrading to Argo CD v2.7.7, there have been changes in the behavior of the pod logs viewer, resulting in the following issues:

  • Horizontal scrolling is independent for each line
  • Logs that are too wide require downloading to be fully readable

I'm wondering if these changes are intentional specifications or if these are bugs.
I find it less convenient compared to the previous version.

To Reproduce

Check pod logs from the pod log viewer.

Expected behavior

  • The ability to scroll horizontally across the entire log instead of on a per-line basis.
  • Being able to view long logs directly within the pod logs viewer.

Screenshots

Version

argocd: v2.7.7+4650bb2.dirty
  BuildDate: 2023-07-05T22:18:46Z
  GitCommit: 4650bb2817c3c81405f40cf77e93ef2b5fb275fb
  GitTreeState: dirty
  GoVersion: go1.20.5
  Compiler: gc
  Platform: darwin/arm64
argocd-server: v2.7.7+4650bb2.dirty

Logs

@Asuforce Asuforce added the bug Something isn't working label Jul 7, 2023
@crenshaw-dev
Copy link
Member

@Asuforce
Copy link
Contributor Author

@crenshaw-dev
Thank you for your sharing. So it is a spec now.

Logs that are too wide require downloading to be fully readable

How about this problem ?

@mhoyer
Copy link
Contributor

mhoyer commented Jul 12, 2023

I can confirm that this UX is not very convenient anymore. I even can't use my horizontal mouse wheel to scroll at all, though Shift+Wheel works. So or so, scrolling single log lines feels just strange at all. v2.7.7 is running here as well.

@alexec
Copy link
Contributor

alexec commented Jul 16, 2023

This may be fixed by #14199. It should fix the need to scroll horizontally long lines; that was my main goal.

I’m not sure about the Shift + Wheel problem. Maybe fixed too.

@crenshaw-dev will this go in v2.7.8?

@alexec alexec self-assigned this Jul 16, 2023
@alexec alexec added the component:ui User interfaces bugs and enhancements label Jul 16, 2023
@Asuforce
Copy link
Contributor Author

@alexec Thank you for your supporting. It fixed on v2.7.9.

@alexec alexec closed this as completed Jul 27, 2023
@maartengo
Copy link

This issue seems to have resurfaced in the latest version:

Recording.2023-11-20.084540.mp4
{
    "Version": "v2.9.1+58b04e5",
    "BuildDate": "2023-11-14T15:08:20Z",
    "GitCommit": "58b04e5e11d007b0518853029ff7612c24a2eb35",
    "GitTreeState": "clean",
    "GoVersion": "go1.21.3",
    "Compiler": "gc",
    "Platform": "linux/amd64",
    "KustomizeVersion": "v5.2.1 2023-10-19T20:13:51Z",
    "HelmVersion": "v3.12.1+gf32a527",
    "KubectlVersion": "v0.24.2",
    "JsonnetVersion": "v0.20.0"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements
Projects
None yet
Development

No branches or pull requests

5 participants