Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/api/badge returns http 400 bad request when app name contains dots #15562

Closed
3 tasks done
SamuraiPrinciple opened this issue Sep 19, 2023 · 1 comment
Closed
3 tasks done
Labels
bug Something isn't working

Comments

@SamuraiPrinciple
Copy link

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

/api/badge?name=app.domain.com no longer renders a bage and returns HTTP 400 bad request

To Reproduce

  • Create an ArgoCD app and name it so that it has a dot in its name (we use domain names for our ArgoCD apps, so something like app.domain.com for example)
  • Try and render the app status badge by requesting /api/badge/name=app.domain.com

This is caused by this commit: 543fc25 because validation.NameIsDNSLabel now fails due to application name containing dots.

Expected behavior

A status badge to be rendered.

Screenshots

Version

argocd: v2.8.4+c279299
  BuildDate: 2023-09-13T19:12:09Z
  GitCommit: c27929928104dc37b937764baf65f38b78930e59
  GitTreeState: clean
  GoVersion: go1.20.6
  Compiler: gc
  Platform: linux/amd64
@SamuraiPrinciple SamuraiPrinciple added the bug Something isn't working label Sep 19, 2023
@SamuraiPrinciple
Copy link
Author

Closing as it's a duplicate - #15507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant