You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The getClusterSharding function is currently implemented in the commands package. This function has important logic that must be properly unit-tested. The commands packages should be kept as lean as possible without any business logic as there are no tests currently in the majority of those packages.
Suggestion:
refactor the getClusterSharding function moving it out of the commands package. The package /controller/sharding seems to be a better place to expose this functionality.
The function getClusterSharding needs to have extensive unit test coverage as it drives important logic on how to infer shardings based on different configurations.
The getClusterSharding function is currently implemented in the
commands
package. This function has important logic that must be properly unit-tested. Thecommands
packages should be kept as lean as possible without any business logic as there are no tests currently in the majority of those packages.Suggestion:
getClusterSharding
function moving it out of thecommands
package. The package/controller/sharding
seems to be a better place to expose this functionality.getClusterSharding
needs to have extensive unit test coverage as it drives important logic on how to infer shardings based on different configurations.Related to #17016 and #17124
Checklist:
argocd version
.Describe the bug
To Reproduce
Expected behavior
Screenshots
Version
Paste the output from `argocd version` here.
Logs
The text was updated successfully, but these errors were encountered: