Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowed concurrent proccessing for plugins #18795

Open
marxus opened this issue Jun 24, 2024 · 0 comments
Open

allowed concurrent proccessing for plugins #18795

marxus opened this issue Jun 24, 2024 · 0 comments
Labels
bug/enhancement component:cmp Config Management Plugin related issues component:config-management Tools specific issues (helm, kustomize etc) component:core Syncing, diffing, cluster state cache enhancement New feature or request type:enhancement

Comments

@marxus
Copy link

marxus commented Jun 24, 2024

Summary

allowed concurrent processing for plugins by copying/linking a ref of the git working state only once

Motivation

monorepo with a lot apps that uses a CMP plugin

there is a design choice on how the CMP on a sidecar is implemented
if you have a large monorepo and you trigger a refresh via a commit it will refresh all the Apps related to that repo, causing Argo to copy the entire repo N amount of times (N being the number of your apps) over to the sidecar, which causes heavy Disk I/O and basically chocking the system.

Unlike the old CMP system which didn't copy the repo N amount of times and allowed concurrent processing.

Proposal

How do you think this should be implemented?

Maybe we can have a shared volume between the repo-server and the CMP sidecar and avoid copying all the time

btw, the section about the custom plugin is the monorepo scaling considerations is misleading. with only Sidecar option on new Argo it should state sorry, no workaround for now.
https://argo-cd.readthedocs.io/en/stable/operator-manual/high_availability/#monorepo-scaling-considerations

@marxus marxus added the enhancement New feature or request label Jun 24, 2024
@agaudreault agaudreault added the component:cmp Config Management Plugin related issues label Jun 26, 2024
@alexmt alexmt added bug/enhancement type:enhancement component:config-management Tools specific issues (helm, kustomize etc) component:core Syncing, diffing, cluster state cache labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/enhancement component:cmp Config Management Plugin related issues component:config-management Tools specific issues (helm, kustomize etc) component:core Syncing, diffing, cluster state cache enhancement New feature or request type:enhancement
Projects
None yet
Development

No branches or pull requests

3 participants