Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Race condition when setting application destination inferred server or name #21201

Closed
wants to merge 2 commits into from
Closed

fix: Race condition when setting application destination inferred server or name #21201

wants to merge 2 commits into from

Conversation

adriananeci
Copy link
Contributor

@adriananeci adriananeci commented Dec 16, 2024 •
edited
Loading

Resolves #21182

Applications shared informer logic was mimicked from the app controller logic

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@adriananeci
fix: Race condition when setting application destination inferred ser…
0cfa4c3 
…ver or name

Signed-off-by: Adrian Aneci <aneci@adobe.com>
@adriananeci adriananeci requested a review from a team as a code owner December 16, 2024 14:36
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Dec 16, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@adriananeci adriananeci mentioned this pull request Dec 16, 2024
Open
3 tasks
@adriananeci
Codegen
650f96c 
Signed-off-by: Adrian Aneci <aneci@adobe.com>
@adriananeci adriananeci requested a review from a team as a code owner December 16, 2024 15:18
@adriananeci
Copy link
Contributor Author

Unfortunately these changes won't solve it 😞 . The race being so nondeterministic I thought this change will be addressing it after running the tests many times locally without any failures 😄 .

@adriananeci adriananeci mentioned this pull request Dec 16, 2024
Closed
14 tasks
@adriananeci
Copy link
Contributor Author

I've raised an alternative PR to temporary avoid running the test when -race flag is enabled, #21204

@codecov Codecov
Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 51.66667% with 29 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@c090f84). Learn more about missing BASE report.
Report is 42 commits behind head on master.

Files with missing lines Patch % Lines
server/server.go 60.78% 17 Missing and 3 partials ⚠️
cmd/argocd-server/commands/argocd_server.go 0.00% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #21201   +/-   ##
=========================================
  Coverage          ?   53.82%           
=========================================
  Files             ?      324           
  Lines             ?    55712           
  Branches          ?        0           
=========================================
  Hits              ?    29985           
  Misses            ?    23121           
  Partials          ?     2606

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adriananeci
Copy link
Contributor Author

Closing in favor of #21189

@adriananeci adriananeci deleted the fix_app_race branch December 21, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Race condition when setting application destination inferred server or name
1 participant
@adriananeci