Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics: Add more automated syncPolicy labels to argocd_app_info metric #21206

Open
Indransh opened this issue Dec 16, 2024 · 2 comments
Open
Labels
component:metrics enhancement New feature or request

Comments

@Indransh
Copy link

Summary

Add more labels to the argocd_app_info metric to reflect the individual automated syncPolicy config. At the moment, this metric has a single autosync_enabled label that is set if spec.syncPolicy.automated != nil.

Motivation

In some cases (e.g. outage situations) it is required to disable autosync for short periods. This is achievable by adding /spec/syncPolicy/automated to ignoreDifferences (or ignoreApplicationDifferences). By design, this has the downside that ArgoCD won't show a diff when autosync is disabled for an Application and users must remember to re-enable it later.

With the argocd_app_info metric, alerts can be triggered using the autosync_enabled label only when autosync is completely disabled for an Application, this enhancement proposal is to add additional labels so alerts can also be triggered if autosync is partially disabled.

Proposal

Add the following labels to the argocd_app_info metric:

  • autosync_prune_enabled
  • autosync_self_heal_enabled
  • autosync_allow_empty_enabled
@Indransh Indransh added the enhancement New feature or request label Dec 16, 2024
@Indransh
Copy link
Author

I'd be interested in submitting a PR if I can get a go-ahead from the project maintainers.

@andrii-korotkov-verkada
Copy link
Contributor

Seems reasonable to me. Feel free to bring up at the next contributors meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:metrics enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants