Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgoCD Sync Waves should be followed during app deletion #3211

Closed
whitleykeith opened this issue Mar 9, 2020 · 1 comment · Fixed by #3959
Closed

ArgoCD Sync Waves should be followed during app deletion #3211

whitleykeith opened this issue Mar 9, 2020 · 1 comment · Fixed by #3959
Labels
component:core Syncing, diffing, cluster state cache enhancement New feature or request type:usability Enhancement of an existing feature
Milestone

Comments

@whitleykeith
Copy link
Contributor

Summary

When deleting an application, Argo should maintain sync waves during deletion at follow the reverse order for deletion.

i.e. I have a application that deploys manifest A at phase 0 and manifest B at phase 1. When deleting the application, it should delete B first and then A.

Motivation

When deploying applications that have an Operator + Custom Resource, we want the deletion to delete the Custom Resource, the operator, and then the CRD. Currently doing this can cause a hang on deletion since sometimes the operator will get deleted first.

Proposal

Sync waves should be following in reverse order during deletion, i.e. delete phase 3 -> phase 2 -> phase 1.

@whitleykeith whitleykeith added the enhancement New feature or request label Mar 9, 2020
@raiviskrumins
Copy link

Having the same issue

@jannfis jannfis added component:core Syncing, diffing, cluster state cache type:usability Enhancement of an existing feature labels May 14, 2020
@alexmt alexmt added this to the v1.7 milestone May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:core Syncing, diffing, cluster state cache enhancement New feature or request type:usability Enhancement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants