Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argo CD does not exclude creationTimestamp from diffing #4157

Closed
alexmt opened this issue Aug 25, 2020 · 1 comment · Fixed by argoproj/gitops-engine#128
Closed

Argo CD does not exclude creationTimestamp from diffing #4157

alexmt opened this issue Aug 25, 2020 · 1 comment · Fixed by argoproj/gitops-engine#128
Labels
bug Something isn't working
Milestone
v1.7

Comments

@alexmt
Copy link
Collaborator

alexmt commented Aug 25, 2020

Describe the bug

Argo CD does not exclude creationTimestamp from diffing. The creationTimestamp is often included in Git manifests and causes false positives during diffing.

Expected behavior

The creationTimestamp should be excluded from diffing.

Version

v1.7.0
@alexmt alexmt added the bug Something isn't working label Aug 25, 2020
@alexmt alexmt added this to the v1.7 milestone Aug 25, 2020
This was referenced Aug 25, 2020
Merged
Closed
@aweis89
Copy link

aweis89 commented Sep 18, 2020 •
edited
Loading

I'm still seeing this when running argocd app diff with the CLI. Notably, this happens even when the creationTimestamp is not part of the git manifests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.7
Development

Successfully merging a pull request may close this issue.

fix: exclude creationTimestamp from diffing alexmt/gitops-engine
2 participants
@alexmt @aweis89