Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep-links to logging facility etc #4281

Closed
boniek83 opened this issue Sep 8, 2020 · 7 comments
Closed

Deep-links to logging facility etc #4281

boniek83 opened this issue Sep 8, 2020 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@boniek83
Copy link

boniek83 commented Sep 8, 2020

Summary

Argo Workflow has ability to add custom links to pods or workflow with templated variables. It is really useful to dynamically generate links to logging system (eg. Granafa Loki instance) and massively eases debugging.

Motivation

Integrate with external tools in company such as logging or opsec. Links right in the ArgoCD lessen operational burden - no additional documentation where to find such tools is necessary. Introducing new tools globally in company is really easy.

Proposal

Argo Workflows already implements this. At least pods and whole project should have custom links.

@boniek83 boniek83 added the enhancement New feature or request label Sep 8, 2020
@jessesuen
Copy link
Member

There's an undocumented feature to add "info items" to an application. It's spec looks like:

project: argo-rollouts
source:
  repoURL: 'https://REDACTED'
  path: argo-rollouts
destination:
  server: https://REDACTED
  namespace: argo-rollouts
info:
  - name: splunk-logs
    value: >-
      https://REDACTED

In the UI it then shows up in the details page:

image

@jessesuen jessesuen added workaround There's a workaround, might not be great, but exists documentation labels Sep 8, 2020
@boniek83
Copy link
Author

boniek83 commented Sep 8, 2020

Not good enough because it doesn't support variables. Without them links are pretty generic and not that useful. This is where most value of this comes from eg. link to logs of specific pod or link to container image security scan of specific pod, specific dashboard etc you get the picture.

@alexec alexec added the good first issue Good for newcomers label Mar 31, 2022
@alexec
Copy link
Contributor

alexec commented Mar 31, 2022

I spoke to @jessesuen and @alexmt yesterday. I think the existing feature could be enhanced to support deep-linking.

@alexec alexec removed the workaround There's a workaround, might not be great, but exists label Mar 31, 2022
@alexec alexec changed the title Argo Workflows-like links in ArgoCD Deep-links to logging facility etc Mar 31, 2022
@alexmt
Copy link
Collaborator

alexmt commented Aug 12, 2022

Proposal had been created #10278

@doshianish8
Copy link
Contributor

@crenshaw-dev Would love to work on this as part of hacktoberfest22

@crenshaw-dev
Copy link
Member

@doshianish8 I might have actually been a bit optimistic adding the hacktoberfest label to this one. 😆 If you look at the proposal and feel up to it though, I'd be happy to help/review!

@gdsoumya
Copy link
Member

Closing this for now as the initial deep links feature has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

7 participants