Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Migrate project summary settings to EditablePanel for parity with rest of UI #4400

Merged
merged 7 commits into from
Sep 24, 2020

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Sep 22, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

@rbreeze rbreeze requested a review from alexmt September 22, 2020 23:00
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2020

Codecov Report

Merging #4400 into master will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4400      +/-   ##
==========================================
+ Coverage   41.18%   41.29%   +0.10%     
==========================================
  Files         122      122              
  Lines       16584    16584              
==========================================
+ Hits         6830     6848      +18     
+ Misses       8772     8750      -22     
- Partials      982      986       +4     
Impacted Files Coverage Δ
controller/appcontroller.go 50.17% <0.00%> (+2.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbfa89d...786212a. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on it @rbreeze !

Added few comments. Also, the orphaned resources panel seems to need a little more polishing. Worked on small PR that implements some ideas: rbreeze#1

  • add icons that visualize enabled/disabled state
  • add help icons with the additional description in tooltip
  • removed redundant 'Orphaned' words from labels within 'Orphaned Resources' panel
  • make sure that positions of edit and view controller are consistent

image

image

ui/src/app/shared/models.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last couple comments. LGTM after addressing them.

@rbreeze rbreeze requested a review from alexmt September 24, 2020 19:45
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @rbreeze

@alexmt alexmt merged commit 4347a3c into argoproj:master Sep 24, 2020
<EditablePanel
save={item => this.saveProject(item)}
values={proj}
title={<React.Fragment>CLUSTER RESOURCE DENY LIST {helpTip('Cluster-scoped K8s API Groups and Kinds which are not permitted to be deployed')}</React.Fragment>}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like this change from blacklist/whitelist to deny list/allow list should have been called out in a commit message / release note...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants