Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Top level indicator when app is overriding parameters #503

Closed
jessesuen opened this issue Aug 8, 2018 · 2 comments
Closed

[UI] Top level indicator when app is overriding parameters #503

jessesuen opened this issue Aug 8, 2018 · 2 comments
Assignees
@merenbach

Comments

@jessesuen
Copy link
Member

When an application has parameter overrides, the source of truth is in two places: git and the app CRD. When this happens, we should have a top level indicator (e.g. caution icon) to warn users that there are parameter overrides.

Instead of a caution icon, this could also potentially be a warning condition.
@jessesuen jessesuen added the P2 label Aug 16, 2018
@jessesuen jessesuen changed the title Top level indicator when app is overriding parameters [UI] Top level indicator when app is overriding parameters Sep 5, 2018
@merenbach merenbach self-assigned this Sep 5, 2018
@merenbach merenbach mentioned this issue Sep 7, 2018
Merged
@jessesuen
Copy link
Member Author

Can we remove this label when there are no overrides?

image

@jessesuen jessesuen reopened this Sep 7, 2018
@merenbach merenbach mentioned this issue Sep 7, 2018
Merged
@merenbach
Copy link
Contributor

@jessesuen should be all fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@merenbach merenbach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@merenbach @jessesuen