Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite custom changes on argocd-ssh-known-hosts-cm when upgrading #5054

Open
simonszu opened this issue Dec 14, 2020 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@simonszu
Copy link

Summary

I have noticed that an upgrade of ArgoCD overwrites the configmap argocd-ssh-known-hosts-cm. This is a bit inconvenient when one has made custom changes, e.g. adding a SSH key for a private repo.

Motivation

This behaviour adds a repetitive additional step for each upgrading. Since it isn't needed to overwrite the configmap on upgrade, this should be handled differently.

Proposal

For now, the upgrade manifest is the same as the install-from-scratch manifest. Maybe it would just be sufficient to provide an upgrade-manifest which does not apply any configmaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant