Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms UX #5262

Closed
jsoref opened this issue Jan 17, 2021 · 2 comments
Closed

Forms UX #5262

jsoref opened this issue Jan 17, 2021 · 2 comments
Assignees
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request type:usability Enhancement of an existing feature ui-polish

Comments

@jsoref
Copy link
Member

jsoref commented Jan 17, 2021

Summary

Forms should behave more or less the same way across the product

Motivation

Inconsistency and surprise are bad

Survey

https://cd.apps.argoproj.io/settings/projects?add=true
image
image

https://cd.apps.argoproj.io/settings/repos?addHTTPSRepo=true
image
image

https://cd.apps.argoproj.io/settings/gpgkeys?addGnuPGPublicKey=true
image
image

https://cd.apps.argoproj.io/settings/certs?addTLSCert=true
image
image

https://cd.apps.argoproj.io/settings/certs?addSSHKnownHosts=true
image
image

https://cd.apps.argoproj.io/settings/repos?addSSHRepo=true
image
image

https://cd.apps.argoproj.io/settings/projects/default?newRole=true
image
image

https://cd.apps.argoproj.io/settings/projects/default?newWindow=true
image
(this form doesn't appear to have any mandatory fields? -- clicking create just triggers an error)
image
oddly the kind field gets a dropdown indicator later...

Proposal

  • consistently use white background (followup to fix: sync repository certificates UI with other pages(#4609) #4971)
  • consistently place create/cancel buttons (below see that some are LTR and some RTL)
  • clearly indicate mandatory fields so users don't have to guess
  • help indicators shouldn't wrap away from their text if it's possible to make the field wider (see DAY OF THE MONTH)
@jsoref jsoref added the enhancement New feature or request label Jan 17, 2021
@jannfis jannfis added component:ui User interfaces bugs and enhancements type:usability Enhancement of an existing feature labels Jan 17, 2021
@saumeya saumeya self-assigned this Feb 10, 2022
@ciiay
Copy link
Contributor

ciiay commented Apr 13, 2022

Hi @jsoref , the PR for this issue has been merged, could you check if this is ready for closing? Thanks!

@jsoref
Copy link
Member Author

jsoref commented Apr 13, 2022

LGTM, thanks.

@jsoref jsoref closed this as completed Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request type:usability Enhancement of an existing feature ui-polish
Projects
None yet
Development

No branches or pull requests

4 participants