Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgoCD is ignoring Helm Release capabilities #7637

Closed
ArieLevs opened this issue Nov 6, 2021 · 2 comments
Closed

ArgoCD is ignoring Helm Release capabilities #7637

ArieLevs opened this issue Nov 6, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@ArieLevs
Copy link

ArieLevs commented Nov 6, 2021

There is a similar issue #7438 regarding same issue that has been closed.
Also seen a fix to the Helm capabilities in 2.2 milestone, can it also include Release part?

Describe the bug

ArgoCD is ignoring Release built-in objects

To Reproduce

Deploy any helm template that includes

{{ if .Release.IsUpgrade }}
SOMETHING HERE
{{ end }}

Expected behavior

ArgoCD should respect helm release capabilities

Version

v2.1.3+d855831
@ArieLevs ArieLevs added the bug Something isn't working label Nov 6, 2021
@jessesuen
Copy link
Member

I answer the question in the discussion: #7496 (comment)

The short answer we cannot achieve this unless Argo CD starts remembering lifecycle information about applications.

@phanama
Copy link
Contributor

phanama commented Aug 23, 2023

@jessesuen At least can the flag be exposed in Application definition for users to set manually? The default should still be .Release.IsInstall, and users can deliberately set the flag after initial installation.

The flag helm template --is-upgrade itself has been available since helm v3.1:
helm/helm@cb81b07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants