-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow providing multiple external URLs in ArgoCD config #8354
Comments
Isn't this a duplicate of #5388, which you already mentioned in your summary? Or is there any substantial difference between the two that I've missed? |
I guess this is a proposal for a PR using |
I too would like to see this implemented. Our use case is when we are trying to deploy a second ArgoCD in a different cluster for blue-green style deployment and need to validate the new installation but still using the same OIDC login. |
I have this issue too. |
Would like to bump this as an issue we are also facing. We have external and internal domains in our infrastructure but are forced to only provide the external domain for SSO redirect. |
Any news on this issue ? |
We have the same needs here, by using ArgoCD with Cognito for SSO. |
+1 |
Merged in #18927 |
I think some of us are pretty eager to see this released... |
I tried it out and it seems good, but #19968 is not-so-good. Can't wait for RC2... |
Summary
As per #5388, it's currently impossible to use multiple external URLs with ArgoCD.
Motivation
The use case here would be accessing ArgoCD via multiple external URLs, for example I have ArgoCD set up on every Kubernetes cluster, which can be referred via multiple hostnames like
argocd.k8s-production.example.com
andargocd.k8s-green.example.com
. Some SSO providers (like Azure AD in my case) support this fully, allowing to specify multiple redirect URLs, and the only blocker is the hardcoded single-url logic in redirect URL verification on ArgoCD side.Proposal
I would implement it by adding
config.urls
parameter besides the existingconfig.url
, which would accept a list of public URLs, then at some point deprecatingconfig.url
. Another approach is disconnecting SSO logic fromconfig.url
and using a separate config key for "allowed URLs".The text was updated successfully, but these errors were encountered: