Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow providing multiple external URLs in ArgoCD config #8354

Closed
zerodayyy opened this issue Feb 3, 2022 · 12 comments
Closed

Allow providing multiple external URLs in ArgoCD config #8354

zerodayyy opened this issue Feb 3, 2022 · 12 comments
Labels
enhancement New feature or request

Comments

@zerodayyy
Copy link

Summary

As per #5388, it's currently impossible to use multiple external URLs with ArgoCD.

Motivation

The use case here would be accessing ArgoCD via multiple external URLs, for example I have ArgoCD set up on every Kubernetes cluster, which can be referred via multiple hostnames like argocd.k8s-production.example.com and argocd.k8s-green.example.com. Some SSO providers (like Azure AD in my case) support this fully, allowing to specify multiple redirect URLs, and the only blocker is the hardcoded single-url logic in redirect URL verification on ArgoCD side.

Proposal

I would implement it by adding config.urls parameter besides the existing config.url, which would accept a list of public URLs, then at some point deprecating config.url. Another approach is disconnecting SSO logic from config.url and using a separate config key for "allowed URLs".

@zerodayyy zerodayyy added the enhancement New feature or request label Feb 3, 2022
@jannfis
Copy link
Member

jannfis commented Feb 4, 2022

Isn't this a duplicate of #5388, which you already mentioned in your summary?

Or is there any substantial difference between the two that I've missed?

@adyanth
Copy link

adyanth commented Mar 5, 2022

I guess this is a proposal for a PR using config.urls.
I would love to see this implemented too.

@mechastorm
Copy link

I too would like to see this implemented. Our use case is when we are trying to deploy a second ArgoCD in a different cluster for blue-green style deployment and need to validate the new installation but still using the same OIDC login.

@SoulKyu
Copy link

SoulKyu commented Feb 22, 2023

I have this issue too.
I have différent user which should access the application from différents URL. This is no't possible actually (using SSO too)

@willh99
Copy link

willh99 commented Mar 31, 2023

Would like to bump this as an issue we are also facing. We have external and internal domains in our infrastructure but are forced to only provide the external domain for SSO redirect.

@SoulKyu
Copy link

SoulKyu commented May 2, 2023

Any news on this issue ?

@KelvinVenancio
Copy link

We have the same needs here, by using ArgoCD with Cognito for SSO.

@thekoma
Copy link
Contributor

thekoma commented Sep 10, 2024

+1

@agaudreault
Copy link
Member

Merged in #18927

@akloss-cibo
Copy link

I think some of us are pretty eager to see this released...

@luispabon
Copy link

@akloss-cibo
Copy link

I tried it out and it seems good, but #19968 is not-so-good. Can't wait for RC2...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests