Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Argo CD manifests on push #8948

Open
crenshaw-dev opened this issue Mar 30, 2022 · 0 comments
Open

Test Argo CD manifests on push #8948

crenshaw-dev opened this issue Mar 30, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@crenshaw-dev
Copy link
Member

Summary

We should do a quick coherence check on the manifests to find simple errors.

Motivation

The wrong command was configured in the manifests for the applicationset controller (#8940). Because we don't tests the manifests, the problem wasn't caught in CI.

Proposal

Add an e2e test that

  1. builds images locally
  2. installs the Argo CD manifests
  3. waits for the resources to be healthy
  4. (optional) perform some trivial task (like sync an app)

If the test is fast, do it on PRs as well as pushes to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant