Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestCustomToolWithSSHGitCreds is flakey #9094

Closed
danielhelfand opened this issue Apr 13, 2022 · 2 comments
Closed

TestCustomToolWithSSHGitCreds is flakey #9094

danielhelfand opened this issue Apr 13, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@danielhelfand
Copy link
Contributor

danielhelfand commented Apr 13, 2022 •
edited
Loading

Summary

TestCustomToolWithSSHGitCreds seems to be flakey as shown in logs here and here and mentioned in #9054.

The cause seems to be that the status for the App doesn't reach a status of Synced. This causes the test to be timed out and fail.

#9054 attempted to fix this, but it does not appear that even 30 seconds is enough some times.

We should consider raising the timeout more or figuring out if the test needs further changes.

The test was introduced in #8389.
@danielhelfand danielhelfand added the enhancement New feature or request label Apr 13, 2022
@crenshaw-dev
Copy link
Member

@danielhelfand I notice that the command being printed by the flakey test shows --timeout 10. I wonder if a second timeout needs to be extended.

@danielhelfand
Copy link
Contributor Author

This test will be removed in #9105 so closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crenshaw-dev @danielhelfand