Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cluster rotate auth to accept cluster name as argument #9554

Closed
danielhelfand opened this issue Jun 1, 2022 · 0 comments · Fixed by #9838
Closed

Allow cluster rotate auth to accept cluster name as argument #9554

danielhelfand opened this issue Jun 1, 2022 · 0 comments · Fixed by #9838
Labels
enhancement New feature or request

Comments

@danielhelfand
Copy link
Contributor

Summary

Similar to #8823, the RotateAuth endpoint for the cluster server should accept the cluster name as a way of knowing token to rotate. At this point, all other endpoints for the cluster server accept both the server and name as ways of identifying a cluster. RotateAuth should be the same.

Motivation

For some users, it is simpler to identify clusters by a name rather than by the server url. It should also be a consistent experience for users interacting with the cluster server.

Proposal

This should be implemented in a way similar to #8823. Also, changing the CLI/UI to allow names should be considered as part of this change to allow users to easily consume this change.

The endpoint func in question is here.

For the CLI, the rotate auth command would need to be changed to also accept the name of the cluster instead of just the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant