feat(controller): Add custom metadata support for AnalysisRun. Fixes #2740

[lukaszgyg]

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed my commits with DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md.

[lukaszgyg]

This PR is the implementation for #2740

[github-actions]

Go Published Test Results

1 950 tests   1 950 ✔️  2m 37s ⏱️
   118 suites         0 💤
       1 files           0 ❌

Results for commit ec61e59.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (04b1e30) 81.62% compared to head (ec61e59) 81.63%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2743   +/-   ##
=======================================
  Coverage   81.62%   81.63%           
=======================================
  Files         133      133           
  Lines       20157    20163    +6     
=======================================
+ Hits        16454    16460    +6     
  Misses       2849     2849           
  Partials      854      854           

Impacted Files	Coverage Δ
rollout/analysis.go	80.96% <100.00%> (+0.33%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[github-actions]

E2E Tests Published Test Results

    4 files      4 suites   3h 22m 41s ⏱️
  96 tests   85 ✔️   5 💤   6 ❌
400 runs  364 ✔️ 20 💤 16 ❌

For more details on these failures, see this check.

Results for commit ec61e59.

♻️ This comment has been updated with latest results.

[zachaller]

Will give this a code review in just a bit, but in the meantime can you also add to the spec docs https://argoproj.github.io/argo-rollouts/features/specification/

[lukaszgyg]

@zachaller I added the docs spec. Can you review the PR?

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
1.7% Duplication

[alexef]

@zachaller I assume this will be part of 1.6, not sooner, or?

[zachaller]

@alexef Yea it would be a new feature not a bug fix so would go in 1.6