feat: enable self service notification support #2930
Conversation
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
…service-zaller Signed-off-by: zachaller <zachaller@users.noreply.github.com>
…service-zaller Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
zachaller
changed the title
zachaller
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2930 +/- ##
==========================================
- Coverage 81.75% 81.74% -0.01%
==========================================
Files 133 133
Lines 20336 20339 +3
==========================================
+ Hits 16625 16627 +2
- Misses 2855 2856 +1
Partials 856 856
☔ View full report in Codecov by Sentry. |
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
| person who can configure notifications in that namespace generally. However, in some cases, it is required to allow end-users to configure notifications | ||
| for their Rollout resources. For example, the end-user can configure notifications for their Rollouts in the namespace where they have access to and their rollout is running in. | ||
|
|
||
| To use this feature all you need to do is create the same configmap named `argo-rollouts-notification-configmap` and possibly |
There was a problem hiding this comment.
Maybe add a link to where this configmap is defined so users have a easy reference to how this configmap is supposed to look like
There was a problem hiding this comment.
In context of the rest of the doc I think the idea of the config map is explained: https://argo-rollouts.readthedocs.io/en/stable/features/notifications/
There was a problem hiding this comment.
The documentation mentions about the argo-rollouts-notification-configmap and shows some simple examples. I think that we should provide a link to the configmap definition with all possible fields it can have. Looking at the doc , I couldn't find such info easily. Is there a place users can look to see the full reference doc?
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Allow rollouts to define configuration for notification engine in the namespace of the rollout resource.
Related docs improvement issue as well since notification docs are so light: #2945