Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in smi.md #3160

Merged
merged 1 commit into from
Nov 10, 2023
Merged

docs: fix typo in smi.md #3160

merged 1 commit into from
Nov 10, 2023

Conversation

dmetz-figma
Copy link
Contributor

@dmetz-figma dmetz-figma commented Nov 8, 2023

Before: "Name of service that sends traffic only to the stable po ds"
After: "Name of service that sends traffic only to the stable pods"

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Before: "Name of service that sends traffic only to the stable po ds"
After: "Name of service that sends traffic only to the stable pods"
Signed-off-by: Daniel Metz <dmetz@figma.com>
Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b46e7a) 81.85% compared to head (04b2086) 81.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3160   +/-   ##
=======================================
  Coverage   81.85%   81.85%           
=======================================
  Files         134      134           
  Lines       20556    20556           
=======================================
  Hits        16826    16826           
  Misses       2866     2866           
  Partials      864      864           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Go Published Test Results

2 083 tests   2 083 ✔️  2m 47s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 04b2086.

Copy link
Contributor

github-actions bot commented Nov 8, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 26m 46s ⏱️
103 tests   91 ✔️   6 💤   6
426 runs  389 ✔️ 24 💤 13

For more details on these failures, see this check.

Results for commit 04b2086.

@zachaller zachaller merged commit e4ac54c into argoproj:master Nov 10, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants