fix: rollouts getting stuck due to bad rs informer updates #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
zachaller
force-pushed
the
fix-rs-informer-update-logic
branch
from
63bddcc to
6e610a4
Compare
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3200 +/- ##
==========================================
- Coverage 81.84% 81.80% -0.04%
==========================================
Files 134 134
Lines 20558 20576 +18
==========================================
+ Hits 16825 16832 +7
- Misses 2869 2875 +6
- Partials 864 869 +5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
…s-informer-update-logic
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
zachaller
added a commit
that referenced
this pull request
Dec 4, 2023
* fix: for rollouts getting stuck due to bad rs informer updates Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix error msg Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * change logic Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * error fmt Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * change if logic Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * add test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * cleanup test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * cleanup test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * do not double call Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> --------- Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
zachaller
added
the
cherry-pick-completed
ashutosh16
pushed a commit
to ashutosh16/argo-rollouts
that referenced
this pull request
Dec 8, 2023
…3200) * fix: for rollouts getting stuck due to bad rs informer updates Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix error msg Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * change logic Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * error fmt Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * change if logic Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * add test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * cleanup test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * cleanup test Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * do not double call Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> --------- Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes: #3080 and re-works the if logic to avoid the
if err==nilconstructs.k8s also does not seem to have a way to test/mock informer update functions but I did add some unit tests for when rs updates fail.