Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixed the key for headers in prometheus based argo analysis #3306

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

Leegin-darknight
Copy link
Contributor

@Leegin-darknight Leegin-darknight commented Jan 11, 2024

The existing key "name" results in an error. The expected key is "key" as defined in the struct:

Key string `json:"key" protobuf:"bytes,1,opt,name=key"`

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Leegin <114397475+Leegin-darknight@users.noreply.github.com>
Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

Go Published Test Results

2 093 tests   2 093 ✅  2m 49s ⏱️
  118 suites      0 💤
    1 files        0 ❌

Results for commit 74a1bed.

Copy link
Contributor

E2E Tests Published Test Results

  4 files    4 suites   3h 25m 50s ⏱️
106 tests  98 ✅  6 💤 2 ❌
428 runs  400 ✅ 24 💤 4 ❌

For more details on these failures, see this check.

Results for commit 74a1bed.

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoluz leoluz merged commit bc992a3 into argoproj:master Jan 11, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants